added kfp presubmit v2 test #890
Conversation
|
related to kubeflow/pipelines#5802 |
| - name: kubeflow-pipelines-v2-test | ||
| cluster: build-kubeflow | ||
| decorate: true | ||
| run_if_changed: "^(v2/.*)|(v2/test/presubmit-v2-tests.sh)$" |
There was a problem hiding this comment.
nit: v2/* already includes the test folder
| run_if_changed: "^(v2/.*)|(v2/test/presubmit-v2-tests.sh)$" | ||
| spec: | ||
| containers: | ||
| - image: gcr.io/google.com/cloudsdktool/cloud-sdk:latest |
There was a problem hiding this comment.
Note, some go tests depend on a real MLMD server at localhost:8080. I think we need one more container for the MLMD server, but I've never set up a sidecar in prow tests before. We need to debug this.
Another approach can be running this test in a KFP pipeline.
There was a problem hiding this comment.
Do we need side car or another KFP pipeline if we added kubectl port-fprward in the script kubeflow/pipelines@57ebac9#diff-88dcf2f21baa096c2451b3d3dfbc18ad795f135bc4b260721d259345aebf1b73R35?
There was a problem hiding this comment.
Ohh, good point! I missed the kubectl port-forward command.
Ideally we should test with an empty MLMD db, because some common code path will only run once, but this is good enough for now.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobgy, capri-xiyue The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@capri-xiyue: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
added kfp presubmit v2 test